Back to All Playbooks
Engineering Leadership

How to Critique Senior Engineer Pull Requests Without Ego Battles

Leaving blunt comments like 'this is bad code' on PRs creates hostile team dynamics. Discover the Socratic code review phrasing that elevates quality effortlessly.

Vishal Verma
Vishal VermaCTO & Co-Founder, Dehurdle
July 04, 20254 min read
How to Critique Senior Engineer Pull Requests Without Ego Battles

The Socratic Code Review Phrasing

"You should not use a nested loop here; it's inefficient."
"How does this nested loop scale when the user array reaches 50,000 records in production? What do you think about using a hash map lookup for $O(1)$ time complexity?"

The 2-Minute Practice Drill

2-Minute Spoken Drill

The 2-Minute Practice Drill

Practice delivering constructive code review feedback in Dehurdle.

Recommended Playbooks